[SVLS-8211] feat: Add timeout for requests to span_dedup_service#986
Merged
[SVLS-8211] feat: Add timeout for requests to span_dedup_service#986
Conversation
Contributor
|
As the dedup service is accumulating more hardcoded configurations (such as capacity and timeouts), it would be beneficial to pass these in as configurable parameters in a follow-up, so they can be adjusted without requiring code changes. |
Contributor
Author
|
@litianningdatadog That's a good suggestion, but I don't see a need for it right now. I'm still not sure why the response fails to be sent, and this PR is just a short-term patch. If we can figure out and fix the root cause, then maybe we can remove the timeout. |
duncanpharvey
pushed a commit
that referenced
this pull request
Mar 10, 2026
## Problem Span dedup service sometimes fails to return the result and thus logs the error: > DD_EXTENSION | ERROR | Failed to send check_and_add response: true I see this error in our Self Monitoring and a customer's account. Also I believe it causes extension to fail to receive traces from the tracer, causing missing traces. This is because the caller of span dedup is in `process_traces()`, which is the function that handles the tracer's HTTP request to send traces. If this function fails to get span dedup result and gets stuck, the HTTP request will time out. ## This PR While I don't yet know what causes the error, this PR adds a patch to mitigate the impact: 1. Change log level from `error` to `warn` 2. Add a timeout of 5 seconds to the span dedup check, so that if the caller doesn't get an answer soon, it defaults to treating the trace as not a duplicate, which is the most common case. ## Testing To merge this PR then check log in self monitoring, as it's hard to run high-volume tests in self monitoring from a non-main branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Span dedup service sometimes fails to return the result and thus logs the error:
I see this error in our Self Monitoring and a customer's account.
Also I believe it causes extension to fail to receive traces from the tracer, causing missing traces. This is because the caller of span dedup is in
process_traces(), which is the function that handles the tracer's HTTP request to send traces. If this function fails to get span dedup result and gets stuck, the HTTP request will time out.This PR
While I don't yet know what causes the error, this PR adds a patch to mitigate the impact:
errortowarnTesting
To merge this PR then check log in self monitoring, as it's hard to run high-volume tests in self monitoring from a non-main branch.